PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Sorting uniques yields incorrectly sorted items when main skill is minion based

Open
#5,002 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

image

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

I understand the sorting might be tricky because some sorting options need to apply to minions, such as DPS or life when a minion skill is selected.

Except some sorting options seem to player-only (strength, dexterity, intelligence, effective hit pool, and so on). So for these, I would expect to have items being sorted based on the character itself rather than the skill selected.

What is the actual behaviour/value?

When sorting unique items, many of the sorting options yields the wrong results.
I identified two cases where sorting results are either alphabetically sorted (case 1) or seemingly random (case 2)

The root cause of the issue seems to be linked with having a Main Skill configured on a minion skill (in my case Absolution).
Selecting a non-minion skill causes the sorting option to yield an adequately sorted list.

Case 1 - Sorting options yielding alphabetically sorted list

Examples (with 1st result highlighted)

  • Sort by Mana:
    image

  • Sort by Strength:
    image

  • Sort by Dexterity:
    image

Case 2 - Sorting options yielding list in seemingly random order

  • Sort by Effective Hit Pool:

    • 1st item: image
    • 2nd item: image
    • 10th item: image
How to reproduce the issue
  1. Add any minion skill as main skill, for example: Absolution
  2. Sort unique items by metrics only affecting the player, for example: Strength, Dexterity, Intelligence or Effective Health Pool
  3. Then switch the main skill to a non-minion skill => results are different from step 2.
Character build code
https://pobb.in/2pE4Szyp5TuB
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is identified in the issue. Load the linked character build, select a minion skill such as Absolution, and reproduce sorting unique items by Strength, Dexterity, Mana, or Effective Hit Pool, then compare with a non-minion main skill. Done means player-only metrics sort consistently regardless of the selected skill, with regression coverage for the reported cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.