PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Make guard skills not affect EHP by default
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
So this is more of a potential discussion than a feature request, but I didn't know what else to put it under.
Half the PoBs that get shared enable Molten Shell, half disables it. Uptime on Molten Shell is not 100%, so it can be pretty misleading. People loading up a PoB will quickly glance at the EHP, and judge its defenses based on that, they generally don't check the breakdown or check if Molten Shell(or some other guard skill) is enabled.
Describe the solution you'd like
My suggestion would be to not include guard skills in the EHP by default, this way every build gets a fair EHP comparison by default. Perhaps add a new "EHP calculation mode" for this.
Describe alternatives you've considered
Another solution would be to base the EHP increase on the uptime of your guard skill, I personally wouldn't prefer this solution, but it is more along the lines of what you've been doing for other EHP calculations.
Additional context
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
En el issue no se mencionan archivos ni tests. Empieza por localizar el cálculo de EHP y el manejo de guard skills; después, revisa cómo afectan las skills habilitadas al valor mostrado. Se considera terminado cuando las guard skills quedan excluidas de EHP de forma predeterminada y cualquier nuevo modo de cálculo se comporta de manera coherente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- game-dev
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100