PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Make guard skills not affect EHP by default
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
So this is more of a potential discussion than a feature request, but I didn't know what else to put it under.
Half the PoBs that get shared enable Molten Shell, half disables it. Uptime on Molten Shell is not 100%, so it can be pretty misleading. People loading up a PoB will quickly glance at the EHP, and judge its defenses based on that, they generally don't check the breakdown or check if Molten Shell(or some other guard skill) is enabled.
Describe the solution you'd like
My suggestion would be to not include guard skills in the EHP by default, this way every build gets a fair EHP comparison by default. Perhaps add a new "EHP calculation mode" for this.
Describe alternatives you've considered
Another solution would be to base the EHP increase on the uptime of your guard skill, I personally wouldn't prefer this solution, but it is more along the lines of what you've been doing for other EHP calculations.
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named in the issue. Start by locating the EHP calculation and guard-skill handling, then review how enabled skills affect the displayed value. Done means guard skills are excluded from EHP by default, with any new calculation mode behaving consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100