PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
"more damage" multipliers not applying to ignite calculations for offhand shield skills
还没有人认领这个 Issue。
- 主要语言
- Lua
- 星标
- 5.4k
- 派生
- 2.4k
- 平均合并
- 1 天 12 小时
- 30 天内合并 PR
- 26
描述
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
"Total More" calculations for ignite damage should include DoT multipliers (e.g. Malevolence, Shaper of Flames, Cruelty, Elemental Overload, etc.) when using offhand Shield Skills (e.g. Shield Charge, Shield Crush).
What is the actual behaviour/value?
When viewing skill calculations for offhand shield skills (e.g. Shield Charge, Shield Crush), several "Total More" (Malevolence, Shaper of Flames, Cruelty, Elemental Overload) modifiers do not apply at all. I verified that the modifiers in question were activated properly by swapping the skill to Fireball, which caused the expected modifiers to show up in the ignite calculations.
How to reproduce the issue
- Equip an offhand shield skill (e.g. Shield Charge, Shield Crush) in the 'Skills' tab.
- Equip a source of 'Total More' damage calculation (Malevolence, Shaper of Flames, Cruelty, Elemental Overload are the ones I tested)
- Look at the 'Calcs' tab, under the ignite section.
- Mouse over 'Total More' line and view the modifiers contributing to the multiplier.
- Swap the skill to Fireball and redo steps 3 and 4 to verify that the modifiers are activated.
Character build code
https://pastebin.com/SY4xhHUT
Screenshots
No response
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
在 Skills 和 Calcs 选项卡中使用副手 Shield Charge 或 Shield Crush 配置复现该问题,然后使用提供的 build code 将 ignite Total More 贡献者与 Fireball 进行比较。跟踪处理这些盾牌技能的计算路径,并确保经过测试的 DoT 乘数出现在 ignite 乘数明细中。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- lua
- 领域
- desktop, game-dev
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100