PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

"more damage" multipliers not applying to ignite calculations for offhand shield skills

Open
#4,451 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

"Total More" calculations for ignite damage should include DoT multipliers (e.g. Malevolence, Shaper of Flames, Cruelty, Elemental Overload, etc.) when using offhand Shield Skills (e.g. Shield Charge, Shield Crush).

What is the actual behaviour/value?

When viewing skill calculations for offhand shield skills (e.g. Shield Charge, Shield Crush), several "Total More" (Malevolence, Shaper of Flames, Cruelty, Elemental Overload) modifiers do not apply at all. I verified that the modifiers in question were activated properly by swapping the skill to Fireball, which caused the expected modifiers to show up in the ignite calculations.

How to reproduce the issue
  1. Equip an offhand shield skill (e.g. Shield Charge, Shield Crush) in the 'Skills' tab.
  2. Equip a source of 'Total More' damage calculation (Malevolence, Shaper of Flames, Cruelty, Elemental Overload are the ones I tested)
  3. Look at the 'Calcs' tab, under the ignite section.
  4. Mouse over 'Total More' line and view the modifiers contributing to the multiplier.
  5. Swap the skill to Fireball and redo steps 3 and 4 to verify that the modifiers are activated.
Character build code
https://pastebin.com/SY4xhHUT
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the Skills and Calcs tabs using an offhand Shield Charge or Shield Crush setup, then compare the ignite Total More contributors with Fireball using the provided build code. Trace the calculation path that handles these shield skills and ensure the tested DoT multipliers appear in the ignite multiplier breakdown.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.