PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Herald of ash not scaling the correct modifiers.

Open
#4,026 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Herald of ash's burning damage is still scaling with fire and elemental damage increases while this shouldn't, herald of ash should only scale with damage over time modifiers (burning, increased (fire or generic) dot, dot (fire or generic) mult and generic damage because they also apply to dots)

What is the actual behaviour/value?

Herald of ash shouldn't scale with fire or elemental damage increases.

How to reproduce the issue

Select herald of ash as your skill, add overkill damage to your liking in the config, then add a fire damage node or an elemental damage node and see the damage increasing.

or if you use the build code / pastebin, hover over the ele node that's assigned by the templar's large ele wheel on the left, and the fire dmg node close by the HP wheel above the templar starting area. you can't miss them if you follow the path.

Build code
https://pastebin.com/Vf4M6CQV 

1 ele node, 1 fire dmg node assigned
Screenshots

https://i.imgur.com/oZ2po9d.jpeg

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Herald of Ash calculation with the supplied build code, overkill configuration, and the referenced fire and elemental nodes. Trace how the displayed burning damage responds to those modifiers and compare it with the listed damage-over-time modifiers. Done means fire and elemental damage increases no longer change Herald of Ash burning damage, while applicable damage-over-time modifiers still do.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.