PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Feature Request - Display order/additional line for (CoC)Triggered spells

Ouverte
#3,863 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

enhancement
Langage dominant
Lua
Étoiles
5.4k
Forks
2.4k
Merge moyen
1 j 12 h
PR mergées (30 j)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

When I try to set up an optimal Cast on Crit setup useful information is on both on the triggering skill and the triggered skill making it a tiny bit annoying to plan around with constant tooltip swapping.

For example let's say you have a Cyclone-CoC-IceNova link. If you want to optimize you gonna have to swap back and forth Cyclone and Ice Nova details under "Main skill" menu on the left when trying to plan around getting the most optimal trigger rate, Cyclone's attack rate, crit rate is visible for Cyclone, and Trigger Rate, Spell Cooldown is on Ice Nova

As an addition, it would be very helpful to have a line where the required triggering skill attack rate is displayed to achieve the highest possible trigger rate using the current setup called something like "Optimal Triggering Skill Attack Rate"

Describe the solution you'd like

Since with one of the latest updates the spell description was updated to give a lot more info, I think it would be nice to modify it and expand it for visual clarity.

When a spell is triggered, It would be helpful to have additional info, currently in POB it looks like this:

  • CoC Triggering skill: Cyclone

followed by regular additional information

The line above is already colored to be highlighted and I think it could be expanded to include additional info on the spell's details page like this:

  • CoC Triggering skill: Cyclone
  • Triggering Skill Effective Crit Chance: x.xx%
  • Triggering Skill Hit rate: x%
  • Triggering Skill Attack Rate: x.xxs
  • "Optimal Triggering Skill Attack Rate" : x.xxs
  • Trigger Rate: x.xxs
  • Effective Trigger Rate: x.xxs
  • Spell Cooldown: x.xxs
Describe alternatives you've considered

Swapping between Cyclone and Ice Nova details and randomly adding/removing attack speed and crit to see when Trigger Rate is the highest with current cooldown reduction %, crit chance, hit chance, etc

Additional context

No response

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

L’issue n’indique aucun fichier, test ou point d’entrée du code. Commencez par localiser l’affichage des détails du sort et les informations existantes sur le déclencheur Cast on Crit, puis suivez le calcul des valeurs demandées pour la compétence déclenchante et le cooldown. Le travail est terminé lorsque la vue du sort déclenché affiche les valeurs supplémentaires convenues et qu’elles correspondent à la configuration actuelle.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
lua
Domaine
desktop
Type d'issue
Fonctionnalité
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.