PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Feature Request - Display order/additional line for (CoC)Triggered spells
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
When I try to set up an optimal Cast on Crit setup useful information is on both on the triggering skill and the triggered skill making it a tiny bit annoying to plan around with constant tooltip swapping.
For example let's say you have a Cyclone-CoC-IceNova link. If you want to optimize you gonna have to swap back and forth Cyclone and Ice Nova details under "Main skill" menu on the left when trying to plan around getting the most optimal trigger rate, Cyclone's attack rate, crit rate is visible for Cyclone, and Trigger Rate, Spell Cooldown is on Ice Nova
As an addition, it would be very helpful to have a line where the required triggering skill attack rate is displayed to achieve the highest possible trigger rate using the current setup called something like "Optimal Triggering Skill Attack Rate"
Describe the solution you'd like
Since with one of the latest updates the spell description was updated to give a lot more info, I think it would be nice to modify it and expand it for visual clarity.
When a spell is triggered, It would be helpful to have additional info, currently in POB it looks like this:
- CoC Triggering skill: Cyclone
followed by regular additional information
The line above is already colored to be highlighted and I think it could be expanded to include additional info on the spell's details page like this:
- CoC Triggering skill: Cyclone
- Triggering Skill Effective Crit Chance: x.xx%
- Triggering Skill Hit rate: x%
- Triggering Skill Attack Rate: x.xxs
- "Optimal Triggering Skill Attack Rate" : x.xxs
- Trigger Rate: x.xxs
- Effective Trigger Rate: x.xxs
- Spell Cooldown: x.xxs
Describe alternatives you've considered
Swapping between Cyclone and Ice Nova details and randomly adding/removing attack speed and crit to see when Trigger Rate is the highest with current cooldown reduction %, crit chance, hit chance, etc
Additional context
No response
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Das Issue nennt keine Datei, keinen Test und keinen Code-Einstiegspunkt. Beginne damit, die Anzeige der Zauberdetails und die vorhandenen Informationen zum Cast on Crit-Trigger zu finden, und verfolge dann, wie die angeforderten Werte für auslösende Fertigkeit und Cooldown berechnet werden. Als erledigt gilt die Aufgabe, wenn die Ansicht des ausgelösten Zaubers die vereinbarten zusätzlichen Werte anzeigt und sie mit der aktuellen Konfiguration übereinstimmen.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- desktop
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100