PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Feature Request - Display order/additional line for (CoC)Triggered spells
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
When I try to set up an optimal Cast on Crit setup useful information is on both on the triggering skill and the triggered skill making it a tiny bit annoying to plan around with constant tooltip swapping.
For example let's say you have a Cyclone-CoC-IceNova link. If you want to optimize you gonna have to swap back and forth Cyclone and Ice Nova details under "Main skill" menu on the left when trying to plan around getting the most optimal trigger rate, Cyclone's attack rate, crit rate is visible for Cyclone, and Trigger Rate, Spell Cooldown is on Ice Nova
As an addition, it would be very helpful to have a line where the required triggering skill attack rate is displayed to achieve the highest possible trigger rate using the current setup called something like "Optimal Triggering Skill Attack Rate"
Describe the solution you'd like
Since with one of the latest updates the spell description was updated to give a lot more info, I think it would be nice to modify it and expand it for visual clarity.
When a spell is triggered, It would be helpful to have additional info, currently in POB it looks like this:
- CoC Triggering skill: Cyclone
followed by regular additional information
The line above is already colored to be highlighted and I think it could be expanded to include additional info on the spell's details page like this:
- CoC Triggering skill: Cyclone
- Triggering Skill Effective Crit Chance: x.xx%
- Triggering Skill Hit rate: x%
- Triggering Skill Attack Rate: x.xxs
- "Optimal Triggering Skill Attack Rate" : x.xxs
- Trigger Rate: x.xxs
- Effective Trigger Rate: x.xxs
- Spell Cooldown: x.xxs
Describe alternatives you've considered
Swapping between Cyclone and Ice Nova details and randomly adding/removing attack speed and crit to see when Trigger Rate is the highest with current cooldown reduction %, crit chance, hit chance, etc
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name a file, test, or code entry point. Start by locating the spell details display and the existing Cast on Crit trigger information, then trace how the requested triggering-skill and cooldown values are calculated. Done means the triggered spell view shows the agreed additional values and they match the current setup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100