PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Feature Request - Display order/additional line for (CoC)Triggered spells

Abierto
#3,863 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

enhancement
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

When I try to set up an optimal Cast on Crit setup useful information is on both on the triggering skill and the triggered skill making it a tiny bit annoying to plan around with constant tooltip swapping.

For example let's say you have a Cyclone-CoC-IceNova link. If you want to optimize you gonna have to swap back and forth Cyclone and Ice Nova details under "Main skill" menu on the left when trying to plan around getting the most optimal trigger rate, Cyclone's attack rate, crit rate is visible for Cyclone, and Trigger Rate, Spell Cooldown is on Ice Nova

As an addition, it would be very helpful to have a line where the required triggering skill attack rate is displayed to achieve the highest possible trigger rate using the current setup called something like "Optimal Triggering Skill Attack Rate"

Describe the solution you'd like

Since with one of the latest updates the spell description was updated to give a lot more info, I think it would be nice to modify it and expand it for visual clarity.

When a spell is triggered, It would be helpful to have additional info, currently in POB it looks like this:

  • CoC Triggering skill: Cyclone

followed by regular additional information

The line above is already colored to be highlighted and I think it could be expanded to include additional info on the spell's details page like this:

  • CoC Triggering skill: Cyclone
  • Triggering Skill Effective Crit Chance: x.xx%
  • Triggering Skill Hit rate: x%
  • Triggering Skill Attack Rate: x.xxs
  • "Optimal Triggering Skill Attack Rate" : x.xxs
  • Trigger Rate: x.xxs
  • Effective Trigger Rate: x.xxs
  • Spell Cooldown: x.xxs
Describe alternatives you've considered

Swapping between Cyclone and Ice Nova details and randomly adding/removing attack speed and crit to see when Trigger Rate is the highest with current cooldown reduction %, crit chance, hit chance, etc

Additional context

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

El issue no indica ningún archivo, prueba ni punto de entrada del código. Empieza localizando la visualización de los detalles del hechizo y la información existente sobre el disparador de Cast on Crit; después, sigue cómo se calculan los valores solicitados de la habilidad que activa y del cooldown. Se considera terminado cuando la vista del hechizo activado muestra los valores adicionales acordados y estos coinciden con la configuración actual.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
desktop
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.