PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Avg Dmg Effect of Exerting Warcries provides a misleading number that has no actual build meaning due to ignoring pre-existing increased damage, when having increased damage with exerted attacks

Open
#3,169 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Avg Dmg Effect of Exerting Warcries section under Calcs should show me the multiplier to damage compared to non-Exerted Attacks.

What is the actual behaviour/value?

Avg Dmg Effect displays a meaningless number in any scenario where a character has increased damage with exerted attacks, and any other source of increased damage.

See https://www.pathofexile.com/forum/view-thread/3170919

The Avg Dmg Effect treats increased damage with exerted attacks as though it were an independent multiplier. However, this does not take into account any pre-existing increased damage, which means that at no point does the Avg Dmg Effect accurately represent any meaningful DPS effect (within the game nor within POB Total DPS).

The most meaningful number to replace this with would be the proportional damage multiplier resulting from the additional increased damage (aka the "more damage" of the increased damage). See "How to reproduce the issue" for a specific example.

How to reproduce the issue
  1. Load https://pastebin.com/b4LZ9vJt
  2. Click to "Calcs"
  3. Select skill "Rage Vortex"
  4. Avg Dmg Effect of the Exerting Warcries section calculates 2.55, which is 1.7 * 1.5, or increased damage multiplier of exerted attacks * more damage multiplier of exerted attacks.
  5. 2.55 is not a meaningful number, because the proportional DPS effect of the increased damage multiplier is less than 1.7, due to the pre-existing increased damage bonuses.
  6. The most meaningful number to replace this with would be 1.7244, which is the actual DPS multiplier resulting from the marginal increased damage bonus (4.68 + 0.70)/4.68 = 1.1496, times the DPS multiplier resulting from more damage 1.5 = 1.7244.
Build code
https://pastebin.com/b4LZ9vJt
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Calcs view with the Avg Dmg Effect of the Exerting Warcries section and reproduce the Rage Vortex example using the linked Pastebin build. Trace how increased damage and more damage are combined; done means the displayed result reflects the marginal DPS multiplier, approximately 1.7244 for the reported example.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.