PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Dark Pact when Cast on Skeleton does not take into account calculated Skeleton Life
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
There is a 'Skill Options' setting to manually input the Life for a targeted Skeleton, but this requires switching to the calcs tab to view skeleton life, remembering the value, returning to the config tab and typing the life of Skeletons after every change in itemization or pathing.
The fact that casts aren't tied to a specific Skeleton prevents Minion Life modifiers from reflecting their changes to the base damage - there is no change to dps or colouring of passive node power.
Could a checkbox be added to the Summon Skeleton skill to automatically use that Skeleton's life when selected?
Or perhaps a dropdownlist in Dark Pact to select the Summon Skeleton skillgem to use for calculation?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Skill Options handling for targeted Skeleton life and the Dark Pact and Summon Skeleton calculation paths. Done means Dark Pact can use the selected Skeleton's calculated life and updates damage when itemization or passive pathing changes, without manual value entry.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100