PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Petrified Blood + Blood magic + Dissolution of the Flesh
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
PB Reserve 35% of life
Life pool became 65%
Now only 65% life could be reserved to Dissolution of the Flesh before death
What is the value from the calculation in Path of Building?
PoB Calculate Maximum hit taken based on full life instead of calculation on unreserved life.
Calculations are correct if you remove Dissolution of the Flesh so I believe it is issue with how it implemented in calculations.
How to reproduce the issue
Check and uncheck PB and look at Phys max hit calculations
PoB for PoE1 build code
https://pobb.in/tjHT2_Ihw41j
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by importing the linked PoE1 build and reproducing the Phys max-hit discrepancy while toggling Petrified Blood. Trace the calculation path for unreserved life, Blood Magic and Dissolution of the Flesh; done means the maximum-hit result matches the in-game 65% available life behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100