NativeScript / NativeScript/nativescript-cli

Using the word "dependencies" in a comment breaks gradle build.

未关闭
#4,558 1 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@rosen-vladimirov 已经在做这个了。

开始于 2019年11月18日。

bug help wanted os: android severity: low
主要语言
JavaScript
星标
1.1k
派生
204
平均合并
1 天 9 小时
30 天内合并 PR
8

描述

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 5.3.1
  • Cross-platform modules: 5.3.1
  • Android Runtime:
  • iOS Runtime (if applicable):
  • Plugin(s):

Describe the bug

I am writing a plugin based on the NativeScript Plugin Seed. If I include the word "dependencies" in a comment in the platforms/android/include.gradle file the build fails with

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle' line: 103

* What went wrong:
Could not compile build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle'.
> startup failed:
  build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle': 103: expecting EOF, found 'comment' @ line 103, column 19.
     dependencies in a comment.

To Reproduce

Edit platforms/android/include.gradle and include the word 'dependencies' in a comment. For example:

// here we have the word dependencies in a comment.   

Expected behavior

It should build.

Sample project

Just add the word "dependencies" in a comment in the include.gradle for the NativeScript Plugin Seed.

Additional context

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。