NativeScript / NativeScript/nativescript-cli

Using the word "dependencies" in a comment breaks gradle build.

Abierto
#4,558 1 comentario 0 reacciones 1 asignado Ver en GitHub

@rosen-vladimirov ya está trabajando en esto.

Desde el 18/11/2019.

bug help wanted os: android severity: low
Lenguaje dominante
JavaScript
Estrellas
1.1k
Forks
204
Merge medio
1 d 9 h
PR fusionados (30 d)
8

Descripción

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 5.3.1
  • Cross-platform modules: 5.3.1
  • Android Runtime:
  • iOS Runtime (if applicable):
  • Plugin(s):

Describe the bug

I am writing a plugin based on the NativeScript Plugin Seed. If I include the word "dependencies" in a comment in the platforms/android/include.gradle file the build fails with

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle' line: 103

* What went wrong:
Could not compile build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle'.
> startup failed:
  build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle': 103: expecting EOF, found 'comment' @ line 103, column 19.
     dependencies in a comment.

To Reproduce

Edit platforms/android/include.gradle and include the word 'dependencies' in a comment. For example:

// here we have the word dependencies in a comment.   

Expected behavior

It should build.

Sample project

Just add the word "dependencies" in a comment in the include.gradle for the NativeScript Plugin Seed.

Additional context

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.