NativeScript / NativeScript/nativescript-cli

Using the word "dependencies" in a comment breaks gradle build.

Offen
#4,558 1 Kommentar 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@rosen-vladimirov arbeitet bereits daran.

Seit 18.11.2019.

bug help wanted os: android severity: low
Vorherrschende Sprache
JavaScript
Sterne
1.1k
Forks
204
Ø Merge
1 T. 9 Std.
Gemergte PRs (30 T.)
8

Beschreibung

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 5.3.1
  • Cross-platform modules: 5.3.1
  • Android Runtime:
  • iOS Runtime (if applicable):
  • Plugin(s):

Describe the bug

I am writing a plugin based on the NativeScript Plugin Seed. If I include the word "dependencies" in a comment in the platforms/android/include.gradle file the build fails with

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle' line: 103

* What went wrong:
Could not compile build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle'.
> startup failed:
  build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle': 103: expecting EOF, found 'comment' @ line 103, column 19.
     dependencies in a comment.

To Reproduce

Edit platforms/android/include.gradle and include the word 'dependencies' in a comment. For example:

// here we have the word dependencies in a comment.   

Expected behavior

It should build.

Sample project

Just add the word "dependencies" in a comment in the include.gradle for the NativeScript Plugin Seed.

Additional context

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.