NativeScript / NativeScript/nativescript-cli

Using the word "dependencies" in a comment breaks gradle build.

Ouverte
#4,558 1 commentaire 0 réactions 1 personne assignée Voir sur GitHub

@rosen-vladimirov y travaille déjà.

Depuis le 18/11/2019.

bug help wanted os: android severity: low
Langage dominant
JavaScript
Étoiles
1.1k
Forks
204
Merge moyen
1 j 9 h
PR mergées (30 j)
8

Description

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 5.3.1
  • Cross-platform modules: 5.3.1
  • Android Runtime:
  • iOS Runtime (if applicable):
  • Plugin(s):

Describe the bug

I am writing a plugin based on the NativeScript Plugin Seed. If I include the word "dependencies" in a comment in the platforms/android/include.gradle file the build fails with

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle' line: 103

* What went wrong:
Could not compile build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle'.
> startup failed:
  build file '/tmp/android-project119319-11583-b7hf7m.ngoip/nativescript_background_geolocation_fbs/build.gradle': 103: expecting EOF, found 'comment' @ line 103, column 19.
     dependencies in a comment.

To Reproduce

Edit platforms/android/include.gradle and include the word 'dependencies' in a comment. For example:

// here we have the word dependencies in a comment.   

Expected behavior

It should build.

Sample project

Just add the word "dependencies" in a comment in the include.gradle for the NativeScript Plugin Seed.

Additional context

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.