NativeScript / NativeScript/nativescript-cli

Potential difference between hashes and files both on device and platforms folder

オープン
#3,796 コメント 0 件 リアクション 0 件 担当者 1 名 GitHub で見る

@KristianDD がすでに取り組んでいます。

2018年11月13日 から。

bug os: android run
主要言語
JavaScript
スター
1.1k
フォーク
204
平均マージ
1日 9時間
マージ済み PR(30日)
8

説明

Please, provide the details below:

Did you verify this is a real problem by searching the NativeScript Forum and the other open issues in this repo?

Yes

Tell us about the problem

There is a chance that hashes on device are updated, when all files are written to the output socket, but the application doesn't manage to read all of them, because it did crash or was manually killed.

The other part of the issue is that files that are removed from the application are removed from the device, but still reside inside the platfroms folder. This prevent us from fixing the previous problem, because we can't detect on initial sync that the hashes file on the device contains hashes of files that are missing in the platforms folder.

After investigating the issues are 3:

  1. Hashes are saved after writing to socket, without waiting for doSync conformation
  2. Remove file while LS is running doesn't trigger prepare for platform
  3. Files that are removed while LS is not running are not detected as change and removed on initial sync.
Which platform(s) does your issue occur on?

iOS/Android/Both

Please provide the following version numbers that your issue occurs with:
  • CLI: (run tns --version to fetch it)
  • Cross-platform modules: (check the 'version' attribute in the
    node_modules/tns-core-modules/package.json file in your project)
  • Runtime(s): (look for the "tns-android" and "tns-ios" properties in the
    package.json file of your project)
  • Plugin(s): (look for the version number in the package.json file of your
    project)
Please tell us how to recreate the issue in as much detail as possible.
Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

Consider using the playground to provide the code you have issues with.

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。