NativeScript / NativeScript/nativescript-cli

Potential difference between hashes and files both on device and platforms folder

未關閉
#3,796 0 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

@KristianDD 已經在處理了。

開始於 2018年11月13日。

bug os: android run
主要語言
JavaScript
星號
1.1k
分支
204
平均合併
1 天 9 小時
30 天內合併 PR
8

描述

Please, provide the details below:

Did you verify this is a real problem by searching the NativeScript Forum and the other open issues in this repo?

Yes

Tell us about the problem

There is a chance that hashes on device are updated, when all files are written to the output socket, but the application doesn't manage to read all of them, because it did crash or was manually killed.

The other part of the issue is that files that are removed from the application are removed from the device, but still reside inside the platfroms folder. This prevent us from fixing the previous problem, because we can't detect on initial sync that the hashes file on the device contains hashes of files that are missing in the platforms folder.

After investigating the issues are 3:

  1. Hashes are saved after writing to socket, without waiting for doSync conformation
  2. Remove file while LS is running doesn't trigger prepare for platform
  3. Files that are removed while LS is not running are not detected as change and removed on initial sync.
Which platform(s) does your issue occur on?

iOS/Android/Both

Please provide the following version numbers that your issue occurs with:
  • CLI: (run tns --version to fetch it)
  • Cross-platform modules: (check the 'version' attribute in the
    node_modules/tns-core-modules/package.json file in your project)
  • Runtime(s): (look for the "tns-android" and "tns-ios" properties in the
    package.json file of your project)
  • Plugin(s): (look for the version number in the package.json file of your
    project)
Please tell us how to recreate the issue in as much detail as possible.
Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

Consider using the playground to provide the code you have issues with.

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。