NativeScript / NativeScript/nativescript-cli

Potential difference between hashes and files both on device and platforms folder

Offen
#3,796 0 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@KristianDD arbeitet bereits daran.

Seit 13.11.2018.

bug os: android run
Vorherrschende Sprache
JavaScript
Sterne
1.1k
Forks
204
Ø Merge
1 T. 9 Std.
Gemergte PRs (30 T.)
8

Beschreibung

Please, provide the details below:

Did you verify this is a real problem by searching the NativeScript Forum and the other open issues in this repo?

Yes

Tell us about the problem

There is a chance that hashes on device are updated, when all files are written to the output socket, but the application doesn't manage to read all of them, because it did crash or was manually killed.

The other part of the issue is that files that are removed from the application are removed from the device, but still reside inside the platfroms folder. This prevent us from fixing the previous problem, because we can't detect on initial sync that the hashes file on the device contains hashes of files that are missing in the platforms folder.

After investigating the issues are 3:

  1. Hashes are saved after writing to socket, without waiting for doSync conformation
  2. Remove file while LS is running doesn't trigger prepare for platform
  3. Files that are removed while LS is not running are not detected as change and removed on initial sync.
Which platform(s) does your issue occur on?

iOS/Android/Both

Please provide the following version numbers that your issue occurs with:
  • CLI: (run tns --version to fetch it)
  • Cross-platform modules: (check the 'version' attribute in the
    node_modules/tns-core-modules/package.json file in your project)
  • Runtime(s): (look for the "tns-android" and "tns-ios" properties in the
    package.json file of your project)
  • Plugin(s): (look for the version number in the package.json file of your
    project)
Please tell us how to recreate the issue in as much detail as possible.
Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

Consider using the playground to provide the code you have issues with.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.