wfd.processing.qrs.xqrs_detect() does not pass the learn parameter to xqrs.detect()

Open
#473 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
data

Research direction

Start in wfd.processing.qrs at xqrs_detect() and inspect its call to xqrs.detect(). Verify that the learn boolean is forwarded, then run the relevant existing tests for QRS detection if available; done means xqrs.detect() receives the value supplied to xqrs_detect().

Written by the indexing model from the issue text.

Description

xqrs_detect() in wfd.processing.qrs takes a boolean learn parameter but it is unused. Should be passed on to xqrs.detect()

Dominant language
Jupyter Notebook
Stars
853
Forks
322
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MIT-LCP/wfdb-python

All issues in MIT-LCP/wfdb-python

Similar issues

More Data Engineering issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.