MIT-LCP / MIT-LCP/wfdb-python

Add validation of segments when writing a `MultiRecord`

Open
#557 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
853
Forks
322
PR merge metrics
No merged PRs in 30d

Description

As mentioned in #555, when writing multisegment records we should validate the segments. A good initial step would be to simply add the already developed _check_segment_cohesion validation to the workflow.

There are likely a number of other validations that should be performed. For example, we may want to confirm that samps_per_frame is set for segments with expanded signals and that their length is as expected.

Please add any additional suggestions for validating the segments below.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no file or test; start by tracing the MultiRecord writing workflow and locating the existing _check_segment_cohesion validation. Use #555 and the current validation as context, then confirm which additional segment checks are in scope and what completion criteria should be applied.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.