wfdb.io.MultiRecord.wrsamp missing option for expanded=True
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 853
- Forks
- 322
- PR merge metrics
- No merged PRs in 30d
Description
wfdb.io.MultiRecord.wrsamp (which just calls 'self.wrheader' and then 'for seg in self.segments: seg.wrsamp') seems to be missing the ability to pass 'expanded=True', as one can with wfdb.io.Record.wrsamp.
This causes checksums to fail as the checks look for things related to 'd_signal' rather than 'e_d_signal', for example.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with wfdb.io.MultiRecord.wrsamp and compare its calls to wfdb.io.Record.wrsamp, focusing on how the expanded option is handled. Verify the behavior against the checksum scenario described for d_signal and e_d_signal; done means MultiRecord.wrsamp supports the requested expanded=True behavior consistently with Record.wrsamp.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100