InsightSoftwareConsortium / InsightSoftwareConsortium/ITKSphinxExamples

compare_to_baseline in parent directory CMakeLists.txt

Aperta
#259 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Jupyter Notebook
Stelle
59
Fork
70
Merge medio
1g 15h
PR unite (30g)
12

Descrizione

Is there a reason why the cookiecutter generates compare_to_baseline() calls for a new example in the parent directory's CMakeLists.txt and not the CMakeLists.txt of the example itself? I just got through a bit of a run around trying to figure how and where these additional tests were being made. In my case, my example didn't generate an image baseline to compare against, and so this was causing errors.

For example:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/8665c931a16d7f6134e7c55818cbe686d3f71f7e/src/Filtering/ImageStatistics/CMakeLists.txt#L35-L38

https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/8665c931a16d7f6134e7c55818cbe686d3f71f7e/src/Filtering/ImageStatistics/StatisticalPropertiesOfRegions/CMakeLists.txt#L24-L25

My naive suggestion is to put that compare_to_baseline() test generation adjacent to the add_test() code.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.