InsightSoftwareConsortium / InsightSoftwareConsortium/ITKSphinxExamples

compare_to_baseline in parent directory CMakeLists.txt

Ouverte
#259 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Jupyter Notebook
Étoiles
59
Forks
70
Merge moyen
1 j 15 h
PR mergées (30 j)
12

Description

Is there a reason why the cookiecutter generates compare_to_baseline() calls for a new example in the parent directory's CMakeLists.txt and not the CMakeLists.txt of the example itself? I just got through a bit of a run around trying to figure how and where these additional tests were being made. In my case, my example didn't generate an image baseline to compare against, and so this was causing errors.

For example:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/8665c931a16d7f6134e7c55818cbe686d3f71f7e/src/Filtering/ImageStatistics/CMakeLists.txt#L35-L38

https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/8665c931a16d7f6134e7c55818cbe686d3f71f7e/src/Filtering/ImageStatistics/StatisticalPropertiesOfRegions/CMakeLists.txt#L24-L25

My naive suggestion is to put that compare_to_baseline() test generation adjacent to the add_test() code.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.