InsightSoftwareConsortium / InsightSoftwareConsortium/ITKSphinxExamples

compare_to_baseline in parent directory CMakeLists.txt

Open
#259 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
59
Forks
70
Avg merge
1d 15h
Merged PRs (30d)
12

Description

Is there a reason why the cookiecutter generates compare_to_baseline() calls for a new example in the parent directory's CMakeLists.txt and not the CMakeLists.txt of the example itself? I just got through a bit of a run around trying to figure how and where these additional tests were being made. In my case, my example didn't generate an image baseline to compare against, and so this was causing errors.

For example:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/8665c931a16d7f6134e7c55818cbe686d3f71f7e/src/Filtering/ImageStatistics/CMakeLists.txt#L35-L38

https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/8665c931a16d7f6134e7c55818cbe686d3f71f7e/src/Filtering/ImageStatistics/StatisticalPropertiesOfRegions/CMakeLists.txt#L24-L25

My naive suggestion is to put that compare_to_baseline() test generation adjacent to the add_test() code.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.