InsightSoftwareConsortium / InsightSoftwareConsortium/ITKSphinxExamples

compare_to_baseline in parent directory CMakeLists.txt

Offen
#259 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Jupyter Notebook
Sterne
59
Forks
70
Ø Merge
1 T. 15 Std.
Gemergte PRs (30 T.)
12

Beschreibung

Is there a reason why the cookiecutter generates compare_to_baseline() calls for a new example in the parent directory's CMakeLists.txt and not the CMakeLists.txt of the example itself? I just got through a bit of a run around trying to figure how and where these additional tests were being made. In my case, my example didn't generate an image baseline to compare against, and so this was causing errors.

For example:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/8665c931a16d7f6134e7c55818cbe686d3f71f7e/src/Filtering/ImageStatistics/CMakeLists.txt#L35-L38

https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/8665c931a16d7f6134e7c55818cbe686d3f71f7e/src/Filtering/ImageStatistics/StatisticalPropertiesOfRegions/CMakeLists.txt#L24-L25

My naive suggestion is to put that compare_to_baseline() test generation adjacent to the add_test() code.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.