GoogleCloudPlatform / GoogleCloudPlatform/python-docs-samples
firestore: samples should include client creation
- 主要言語
- Jupyter Notebook
- スター
- 8.1k
- フォーク
- 6.7k
- 平均マージ
- 4日 2時間
- マージ済み PR(30日)
- 16
説明
Currently, we have [one sample for creating a client](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/4282aa905763af06354225ae0f422c09201b41da/firestore/cloud-async-client/snippets.py#L27), and the others [assume the client already exists](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/4282aa905763af06354225ae0f422c09201b41da/firestore/cloud-async-client/snippets.py#L36).
This causes problems, because we have both a sync and an async client, and using the wrong client leads to errors. When the samples are viewed stand-alone, they don't give the proper context
We should instead include the creation of the client (and any important imports) as part of each sample, so they can better stand alone
コントリビューションガイド
評価
この issue はまだ評価されていません。