GoogleCloudPlatform / GoogleCloudPlatform/python-docs-samples

firestore: samples should include client creation

Abierto
#11,993 0 comentarios 1 reacción 1 asignado Asignado a @daniel-sanche Ver en GitHub
api: firestore priority: p3 samples triage me type: feature request
Lenguaje dominante
Jupyter Notebook
Estrellas
8.1k
Forks
6.7k
Merge medio
4 d 2 h
PR fusionados (30 d)
16

Descripción

Currently, we have [one sample for creating a client](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/4282aa905763af06354225ae0f422c09201b41da/firestore/cloud-async-client/snippets.py#L27), and the others [assume the client already exists](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/4282aa905763af06354225ae0f422c09201b41da/firestore/cloud-async-client/snippets.py#L36).

This causes problems, because we have both a sync and an async client, and using the wrong client leads to errors. When the samples are viewed stand-alone, they don't give the proper context

We should instead include the creation of the client (and any important imports) as part of each sample, so they can better stand alone

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.