GoogleCloudPlatform / GoogleCloudPlatform/python-docs-samples

firestore: samples should include client creation

未關閉
#11,993 0 則留言 1 個 reaction 已指派 1 人 已指派給 @daniel-sanche 在 GitHub 檢視
api: firestore priority: p3 samples triage me type: feature request
主要語言
Jupyter Notebook
星號
8.1k
分支
6.7k
平均合併
4 天 2 小時
30 天內合併 PR
16

描述

Currently, we have [one sample for creating a client](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/4282aa905763af06354225ae0f422c09201b41da/firestore/cloud-async-client/snippets.py#L27), and the others [assume the client already exists](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/4282aa905763af06354225ae0f422c09201b41da/firestore/cloud-async-client/snippets.py#L36).

This causes problems, because we have both a sync and an async client, and using the wrong client leads to errors. When the samples are viewed stand-alone, they don't give the proper context

We should instead include the creation of the client (and any important imports) as part of each sample, so they can better stand alone

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。