GoogleCloudPlatform / GoogleCloudPlatform/functions-framework-python

`uvicorn-worker` requires `gunicorn` which is not available on Windows

未關閉
#428 0 則留言 0 個 reaction 已指派 1 人 已被 @taeold 認領 在 GitHub 檢視
bug P2
主要語言
Python
星號
968
分支
128
PR 合併指標
30 天內沒有已合併 PR

描述

The package has an unconditional dependency on `uvicorn-worker`:

https://github.com/GoogleCloudPlatform/functions-framework-python/blob/d13d9aa4666b553e0e435813ab799c6f43e96bd8/pyproject.toml#L35

However, `uvicorn-worker` depends on `gunicorn` which isn't available on Windows:

https://github.com/Kludex/uvicorn-worker/blob/cd29cc6447cff3abc968e930023dc97e5e5080f9/pyproject.toml#L26

FWICS the dependency is actually unconditional:

https://github.com/Kludex/uvicorn-worker/blob/cd29cc6447cff3abc968e930023dc97e5e5080f9/uvicorn_worker/_workers.py#L39-L40

Does that mean that the `uvicorn-worker` dependency should be also skipped on Windows, like the direct `gunicorn` dependency is?

https://github.com/GoogleCloudPlatform/functions-framework-python/blob/d13d9aa4666b553e0e435813ab799c6f43e96bd8/pyproject.toml#L29

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。