GoogleCloudPlatform / GoogleCloudPlatform/functions-framework-python

`uvicorn-worker` requires `gunicorn` which is not available on Windows

Aperta
#428 0 commenti 0 reazioni 1 assegnatario Rivendicata da @taeold Vedi su GitHub
bug P2
Lingua principale
Python
Stelle
968
Fork
128
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The package has an unconditional dependency on `uvicorn-worker`:

https://github.com/GoogleCloudPlatform/functions-framework-python/blob/d13d9aa4666b553e0e435813ab799c6f43e96bd8/pyproject.toml#L35

However, `uvicorn-worker` depends on `gunicorn` which isn't available on Windows:

https://github.com/Kludex/uvicorn-worker/blob/cd29cc6447cff3abc968e930023dc97e5e5080f9/pyproject.toml#L26

FWICS the dependency is actually unconditional:

https://github.com/Kludex/uvicorn-worker/blob/cd29cc6447cff3abc968e930023dc97e5e5080f9/uvicorn_worker/_workers.py#L39-L40

Does that mean that the `uvicorn-worker` dependency should be also skipped on Windows, like the direct `gunicorn` dependency is?

https://github.com/GoogleCloudPlatform/functions-framework-python/blob/d13d9aa4666b553e0e435813ab799c6f43e96bd8/pyproject.toml#L29

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.