GoogleCloudPlatform / GoogleCloudPlatform/functions-framework-python

`uvicorn-worker` requires `gunicorn` which is not available on Windows

未关闭
#428 0 条评论 0 个 reaction 已指派 1 人 已被 @taeold 认领 在 GitHub 查看
bug P2
主要语言
Python
星标
968
派生
128
PR 合并指标
30 天内没有已合并 PR

描述

The package has an unconditional dependency on `uvicorn-worker`:

https://github.com/GoogleCloudPlatform/functions-framework-python/blob/d13d9aa4666b553e0e435813ab799c6f43e96bd8/pyproject.toml#L35

However, `uvicorn-worker` depends on `gunicorn` which isn't available on Windows:

https://github.com/Kludex/uvicorn-worker/blob/cd29cc6447cff3abc968e930023dc97e5e5080f9/pyproject.toml#L26

FWICS the dependency is actually unconditional:

https://github.com/Kludex/uvicorn-worker/blob/cd29cc6447cff3abc968e930023dc97e5e5080f9/uvicorn_worker/_workers.py#L39-L40

Does that mean that the `uvicorn-worker` dependency should be also skipped on Windows, like the direct `gunicorn` dependency is?

https://github.com/GoogleCloudPlatform/functions-framework-python/blob/d13d9aa4666b553e0e435813ab799c6f43e96bd8/pyproject.toml#L29

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。