GoogleCloudPlatform / GoogleCloudPlatform/functions-framework-python

`uvicorn-worker` requires `gunicorn` which is not available on Windows

Ouverte
#428 0 commentaires 0 réactions 1 personne assignée Réclamée par @taeold Voir sur GitHub
bug P2
Langage dominant
Python
Étoiles
968
Forks
128
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

The package has an unconditional dependency on `uvicorn-worker`:

https://github.com/GoogleCloudPlatform/functions-framework-python/blob/d13d9aa4666b553e0e435813ab799c6f43e96bd8/pyproject.toml#L35

However, `uvicorn-worker` depends on `gunicorn` which isn't available on Windows:

https://github.com/Kludex/uvicorn-worker/blob/cd29cc6447cff3abc968e930023dc97e5e5080f9/pyproject.toml#L26

FWICS the dependency is actually unconditional:

https://github.com/Kludex/uvicorn-worker/blob/cd29cc6447cff3abc968e930023dc97e5e5080f9/uvicorn_worker/_workers.py#L39-L40

Does that mean that the `uvicorn-worker` dependency should be also skipped on Windows, like the direct `gunicorn` dependency is?

https://github.com/GoogleCloudPlatform/functions-framework-python/blob/d13d9aa4666b553e0e435813ab799c6f43e96bd8/pyproject.toml#L29

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.