G-Node / G-Node/python-odml

Refactor of terminology retrieval of sections

Đang mở
#134 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
terminology v1.4
Ngôn ngữ chính
Python
Star
25
Fork
30
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Currently the terminology equivalent of a Section is found in the given repository by matching the Section type.

This is problematic for the following reason: A Section type, as I understood it so far, is meant to group related Sections to an superior class. For example, two different Electrodes from different vendors with different Properties can be grouped via their type which could be 'electrode', even if the Section names are vendor-specific. In such a case, the function get_terminology_equivalent() will currently unfortunately only return the first Section with the type 'electrode' and ignore the second Section in the repository.

Of course one could provide always a unique Section type to avoid this, but I think then one could directly use the Section Name instead and the possibility an overall classification method for Sections is lost.

Instead one could return a list of all sections with the stated type and also use in addition other attributes to retrieve terminologies.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.