G-Node / G-Node/python-odml

Refactor of terminology retrieval of sections

Offen
#134 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
terminology v1.4
Vorherrschende Sprache
Python
Sterne
25
Forks
30
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Currently the terminology equivalent of a Section is found in the given repository by matching the Section type.

This is problematic for the following reason: A Section type, as I understood it so far, is meant to group related Sections to an superior class. For example, two different Electrodes from different vendors with different Properties can be grouped via their type which could be 'electrode', even if the Section names are vendor-specific. In such a case, the function get_terminology_equivalent() will currently unfortunately only return the first Section with the type 'electrode' and ignore the second Section in the repository.

Of course one could provide always a unique Section type to avoid this, but I think then one could directly use the Section Name instead and the possibility an overall classification method for Sections is lost.

Instead one could return a list of all sections with the stated type and also use in addition other attributes to retrieve terminologies.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.