G-Node / G-Node/python-odml

Refactor of terminology retrieval of sections

未关闭
#134 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
terminology v1.4
主要语言
Python
星标
25
派生
30
PR 合并指标
30 天内没有已合并 PR

描述

Currently the terminology equivalent of a Section is found in the given repository by matching the Section type.

This is problematic for the following reason: A Section type, as I understood it so far, is meant to group related Sections to an superior class. For example, two different Electrodes from different vendors with different Properties can be grouped via their type which could be 'electrode', even if the Section names are vendor-specific. In such a case, the function get_terminology_equivalent() will currently unfortunately only return the first Section with the type 'electrode' and ignore the second Section in the repository.

Of course one could provide always a unique Section type to avoid this, but I think then one could directly use the Section Name instead and the possibility an overall classification method for Sections is lost.

Instead one could return a list of all sections with the stated type and also use in addition other attributes to retrieve terminologies.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。