Comcast / Comcast/patternlab-edition-node-webpack

Change `from` pattern for copying font files

未关闭
#33 9 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
128
派生
92
PR 合并指标
30 天内没有已合并 PR

描述

**Current situation:** [Line 77 of the Webpack configuration](https://github.com/Comcast/patternlab-edition-node-webpack/blob/93d87fc5d1ce09d24aa8a85e7aeef87a445ec816/webpack.config.babel.js#L77) defines the glob pattern for copying fonts from the `source` to the `public` folder. The pattern is currently defined as `./*`.

**Proposed improvement:** I would like to update this pattern to `./**/*.*`, as is already the case for images, so that font files which are located in their own subfolders also match the pattern. In my experience, this is frequently the case and changing the pattern would save others the time I spent last Friday trying to debug why my fonts are not being copied over. 😅

I'm happy to open a pull request if you consider this a desirable improvement.

贡献指南

打开贡献指南

调研方向

打开 webpack.config.babel.js 并检查第 77 行,然后将字体复制模式与图像复制模式进行比较。验证已完成的更改是否匹配嵌套源子文件夹中的字体文件,并将它们复制到相应的公共位置。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, node.js, webpack
领域
build-system
Issue 类型
缺陷
难度
1/5
预计耗时
1 小时以内
活跃度
停滞
描述清晰度
描述清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。