Comcast / Comcast/patternlab-edition-node-webpack

Change `from` pattern for copying font files

Aperta
#33 9 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
128
Fork
92
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

**Current situation:** [Line 77 of the Webpack configuration](https://github.com/Comcast/patternlab-edition-node-webpack/blob/93d87fc5d1ce09d24aa8a85e7aeef87a445ec816/webpack.config.babel.js#L77) defines the glob pattern for copying fonts from the `source` to the `public` folder. The pattern is currently defined as `./*`.

**Proposed improvement:** I would like to update this pattern to `./**/*.*`, as is already the case for images, so that font files which are located in their own subfolders also match the pattern. In my experience, this is frequently the case and changing the pattern would save others the time I spent last Friday trying to debug why my fonts are not being copied over. 😅

I'm happy to open a pull request if you consider this a desirable improvement.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.