Comcast / Comcast/patternlab-edition-node-webpack

Change `from` pattern for copying font files

Offen
#33 9 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
128
Forks
92
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

**Current situation:** [Line 77 of the Webpack configuration](https://github.com/Comcast/patternlab-edition-node-webpack/blob/93d87fc5d1ce09d24aa8a85e7aeef87a445ec816/webpack.config.babel.js#L77) defines the glob pattern for copying fonts from the `source` to the `public` folder. The pattern is currently defined as `./*`.

**Proposed improvement:** I would like to update this pattern to `./**/*.*`, as is already the case for images, so that font files which are located in their own subfolders also match the pattern. In my experience, this is frequently the case and changing the pattern would save others the time I spent last Friday trying to debug why my fonts are not being copied over. 😅

I'm happy to open a pull request if you consider this a desirable improvement.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.