Comcast / Comcast/patternlab-edition-node-webpack

Change `from` pattern for copying font files

Abierto
#33 9 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
128
Forks
92
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Current situation:** [Line 77 of the Webpack configuration](https://github.com/Comcast/patternlab-edition-node-webpack/blob/93d87fc5d1ce09d24aa8a85e7aeef87a445ec816/webpack.config.babel.js#L77) defines the glob pattern for copying fonts from the `source` to the `public` folder. The pattern is currently defined as `./*`.

**Proposed improvement:** I would like to update this pattern to `./**/*.*`, as is already the case for images, so that font files which are located in their own subfolders also match the pattern. In my experience, this is frequently the case and changing the pattern would save others the time I spent last Friday trying to debug why my fonts are not being copied over. 😅

I'm happy to open a pull request if you consider this a desirable improvement.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.