CodeEditApp / CodeEditApp/CodeEdit

🧹 Refactor CodeEditCli

Đang mở
#866 9 bình luận 1 reaction 1 người được giao Được @lukepistrol nhận Xem trên GitHub
Ngôn ngữ chính
Swift
Star
23k
Fork
1.2k
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

## Current Situation

~~At the moment~~ [Previously] the `CodeEditCli` is just a standalone SPM package in our main repo:

> https://github.com/CodeEditApp/CodeEdit/tree/main/CodeEditTests

**Edit:** Now it is in the CodeEditCLI repo.

The built binary is then included as a resource in our main workspace:

Screenshot 2022-12-06 at 01 20 44

## The Problem

The problem with this approach apart from having a binary in our sources, which technically isn't needed, is that it prevents our app from notarizing.

## Proposed Solution

~~I suggest moving the `CodeEditCli` package to a new repo (like `CodeEditTextView`) and then attach the binary to a tagged release as an artifact.~~

I may also suggest renaming the artifact to `codeedit-cli` in order to make clear what the binary really is. An alias `codeedit` can always be created by the user if needed.

This would mean the main app needs to download the latest artifact and move it to the according location in `GeneralPreferencesView.swift:215`. The location should be `/usr/local/bin/codeedit`.

Additionally we could also add it to `homebrew` as a formula `codeedit-cli`.

Please let me know what you think about that approach and let's discuss what could be improved further in this regard. I then will create the repo in the organization.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.