CodeEditApp / CodeEditApp/CodeEdit

🧹 Refactor CodeEditCli

未關閉
#866 9 則留言 1 個 reaction 已指派 1 人 已被 @lukepistrol 認領 在 GitHub 檢視
主要語言
Swift
星號
23k
分支
1.2k
PR 合併指標
30 天內沒有已合併 PR

描述

## Current Situation

~~At the moment~~ [Previously] the `CodeEditCli` is just a standalone SPM package in our main repo:

> https://github.com/CodeEditApp/CodeEdit/tree/main/CodeEditTests

**Edit:** Now it is in the CodeEditCLI repo.

The built binary is then included as a resource in our main workspace:

Screenshot 2022-12-06 at 01 20 44

## The Problem

The problem with this approach apart from having a binary in our sources, which technically isn't needed, is that it prevents our app from notarizing.

## Proposed Solution

~~I suggest moving the `CodeEditCli` package to a new repo (like `CodeEditTextView`) and then attach the binary to a tagged release as an artifact.~~

I may also suggest renaming the artifact to `codeedit-cli` in order to make clear what the binary really is. An alias `codeedit` can always be created by the user if needed.

This would mean the main app needs to download the latest artifact and move it to the according location in `GeneralPreferencesView.swift:215`. The location should be `/usr/local/bin/codeedit`.

Additionally we could also add it to `homebrew` as a formula `codeedit-cli`.

Please let me know what you think about that approach and let's discuss what could be improved further in this regard. I then will create the repo in the organization.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。