CodeEditApp / CodeEditApp/CodeEdit

🧹 Refactor CodeEditCli

未关闭
#866 9 条评论 1 个 reaction 已指派 1 人 已被 @lukepistrol 认领 在 GitHub 查看
主要语言
Swift
星标
23k
派生
1.2k
PR 合并指标
30 天内没有已合并 PR

描述

## Current Situation

~~At the moment~~ [Previously] the `CodeEditCli` is just a standalone SPM package in our main repo:

> https://github.com/CodeEditApp/CodeEdit/tree/main/CodeEditTests

**Edit:** Now it is in the CodeEditCLI repo.

The built binary is then included as a resource in our main workspace:

Screenshot 2022-12-06 at 01 20 44

## The Problem

The problem with this approach apart from having a binary in our sources, which technically isn't needed, is that it prevents our app from notarizing.

## Proposed Solution

~~I suggest moving the `CodeEditCli` package to a new repo (like `CodeEditTextView`) and then attach the binary to a tagged release as an artifact.~~

I may also suggest renaming the artifact to `codeedit-cli` in order to make clear what the binary really is. An alias `codeedit` can always be created by the user if needed.

This would mean the main app needs to download the latest artifact and move it to the according location in `GeneralPreferencesView.swift:215`. The location should be `/usr/local/bin/codeedit`.

Additionally we could also add it to `homebrew` as a formula `codeedit-cli`.

Please let me know what you think about that approach and let's discuss what could be improved further in this regard. I then will create the repo in the organization.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。