BlockchainCommons / BlockchainCommons/bc-libs-java

[SSKR] Not needed Android resources included

オープン
#6 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Java
スター
4
フォーク
4
PR マージ指標
30日以内にマージされた PR はありません

説明

Reporting this issue for **SSKR** lib but I believe this could be happening to the rest of the ecosystem.

There are certain Android resources in the android folder from **SSKR** lib that get included in the aar generated library and so included in the project that is using the file. These resources (mipmap, values, colors...) are not needed and they add some extra space to the APK. Launcher icon is overriding the one in the app using the library (if using the same name).

Also the manifest is specifying the `allowBackup=true`, which forces apps using the library to add a replace clause in the manifest.

I'm preparing a PR to fix this. I won't include the rest of the libs as it will require testing, and we don't have in place any project using the rest of the libs just yet.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。