BlockchainCommons / BlockchainCommons/bc-libs-java

[SSKR] Not needed Android resources included

Ouverte
#6 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Java
Étoiles
4
Forks
4
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Reporting this issue for **SSKR** lib but I believe this could be happening to the rest of the ecosystem.

There are certain Android resources in the android folder from **SSKR** lib that get included in the aar generated library and so included in the project that is using the file. These resources (mipmap, values, colors...) are not needed and they add some extra space to the APK. Launcher icon is overriding the one in the app using the library (if using the same name).

Also the manifest is specifying the `allowBackup=true`, which forces apps using the library to add a replace clause in the manifest.

I'm preparing a PR to fix this. I won't include the rest of the libs as it will require testing, and we don't have in place any project using the rest of the libs just yet.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start in the SSKR library's android folder and inspect how its resources and manifest are packaged into the generated AAR. Verify that unnecessary mipmap, values, and color resources no longer reach consuming apps, that launcher icons are not overridden, and that allowBackup does not force a manifest replacement clause.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
android, java
Domaine
mobile
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.