BlockchainCommons / BlockchainCommons/bc-libs-java

[SSKR] Not needed Android resources included

Offen
#6 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Java
Sterne
4
Forks
4
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Reporting this issue for **SSKR** lib but I believe this could be happening to the rest of the ecosystem.

There are certain Android resources in the android folder from **SSKR** lib that get included in the aar generated library and so included in the project that is using the file. These resources (mipmap, values, colors...) are not needed and they add some extra space to the APK. Launcher icon is overriding the one in the app using the library (if using the same name).

Also the manifest is specifying the `allowBackup=true`, which forces apps using the library to add a replace clause in the manifest.

I'm preparing a PR to fix this. I won't include the rest of the libs as it will require testing, and we don't have in place any project using the rest of the libs just yet.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.