Azure / Azure/data-api-builder

Check if DbType is required, since now we are introducing SqlDbType

Open
#2,128 1 comment 0 reactions 0 assignees View on GitHub
refactor
Dominant language
C#
Stars
1.5k
Forks
372
Avg merge
3d 22h
Merged PRs (30d)
9

Description

Bloating a ParamDefinition/ColumnDefinition with fields not relevant for every database seems not to be the best approach here.

_Originally posted by @ayush3797 in https://github.com/Azure/data-api-builder/pull/2052#discussion_r1535448998_

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the ParamDefinition and ColumnDefinition models and how DbType and SqlDbType are used across database providers. Determine whether DbType is still required and how provider-specific fields should be represented without burdening unrelated databases. Done means the model design is agreed and the affected usage and tests reflect that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend-api-design, databases
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.