Azure / Azure/AzLoadBalancerMigration

🪲 Bug Report - AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

未关闭
#158 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
Bicep
星标
11
派生
18
平均合并
1 天 8 小时
30 天内合并 PR
3

描述

## Describe the bug
AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

## To Reproduce

Steps to reproduce the behavior:

1. Excute the script to the VM with no public IP address resource in given AvSet.
2. Logged: `[WARNING] VM '' does not have any public IP addresses attached. Skipping upgrade.`
4. Then Logged `[INFO] ####### Upgrade process complete. #######`. The other VMs which has public IP addresses are also skipped.

## Expected behavior
The VMs which has public IP addresses should be upgraded.
The VMs which has no public IP addresses should be skipped.

"return" statements in line 224 and 235 should be replaced in "continue" statements.

## Screenshots 📷

Image

## Additional context - please include:

- Version of the AzureBasicLoadBalancerUpgrade module you are running (see: `Get-Module AzureBasicLoadBalancerUpgrade` after importing the module.): 1.0.0

Image

- Version of PowerShell you are running (`$PSVersionTable`)

Image

- The JSON View or template of the VMSS and Load Balancer(s) to be migrated
N/A

贡献指南

这个仓库没有索引到贡献指南

调研方向

从 AzureAvSetBasicPublicIPUpgrade 模块中第 224 行和第 235 行附近开始,issue 在这里指出了 return 语句。使用一个没有 public IP 的 VM 和其他具有 public IP 的 VM 重现该情况;完成的标准是前者被跳过,而后者继续执行 upgrade 流程。

由索引模型根据 Issue 内容生成。

评估

技术栈
azure, powershell
领域
cloud, infrastructure
Issue 类型
缺陷
难度
1/5
预计耗时
1 小时以内
活跃度
停滞
描述清晰度
描述清楚
新手友好度
58/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。