Azure / Azure/AzLoadBalancerMigration

🪲 Bug Report - AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

Ouverte
#158 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
Bicep
Étoiles
11
Forks
18
Merge moyen
1 j 8 h
PR mergées (30 j)
3

Description

## Describe the bug
AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

## To Reproduce

Steps to reproduce the behavior:

1. Excute the script to the VM with no public IP address resource in given AvSet.
2. Logged: `[WARNING] VM '' does not have any public IP addresses attached. Skipping upgrade.`
4. Then Logged `[INFO] ####### Upgrade process complete. #######`. The other VMs which has public IP addresses are also skipped.

## Expected behavior
The VMs which has public IP addresses should be upgraded.
The VMs which has no public IP addresses should be skipped.

"return" statements in line 224 and 235 should be replaced in "continue" statements.

## Screenshots 📷

Image

## Additional context - please include:

- Version of the AzureBasicLoadBalancerUpgrade module you are running (see: `Get-Module AzureBasicLoadBalancerUpgrade` after importing the module.): 1.0.0

Image

- Version of PowerShell you are running (`$PSVersionTable`)

Image

- The JSON View or template of the VMSS and Load Balancer(s) to be migrated
N/A

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Start in the AzureAvSetBasicPublicIPUpgrade module around lines 224 and 235, where the issue identifies the return statements. Reproduce the case with a VM lacking a public IP and other VMs with public IPs; done means the former is skipped while the latter continue through the upgrade process.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
azure, powershell
Domaine
cloud, infrastructure
Type d'issue
Bug
Difficulté
1/5
Temps estimé
Moins d'une heure
Activité
À l'abandon
Clarté
Clairement spécifiée
Accessibilité débutants
58/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.